Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most-times unnecessary client reconfiguration #1477

Draft
wants to merge 1 commit into
base: dev/3.0.0
Choose a base branch
from

Conversation

valaphee
Copy link

@valaphee valaphee commented Dec 17, 2024

This removes the configuration phase, as it seems that the client sometimes doesn't transition correctly

This PR is not intended to be merged yet, and is just a quick fix for server owners, as it completely ignores the possibility of servers with different registries and data packs. (and is made so that the diff is as small as possible)

@CullanP
Copy link

CullanP commented Dec 24, 2024

This also happens on our network so we were looking for solutions, whilst this works, there seems to be random protocol error kicks on 1.21+ client with viaversion and equipment packets, you also cannot seem to join 1.8 servers using this without getting kicked for protocol network errors. This could just be related to the 1.8 server issue as well, the equipment packet issue is the only one I've seen so far at least when using 1.21 server version. I can't say if this issue is specifically velocity related yet, but we're large enough to notice it with some players getting stuck on dirt screen and none of our plugins mess with config phase so it's not a plugin issue. The issue with equipment packets is odd because it sometimes happens like 5 seconds after joining, while others are instant, does not happen on our live proxy without this patch, so something must be causing kicks when using this patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants